Paulo Zanoni <przanoni@xxxxxxxxx> writes: > From: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx> > > Hi > > We always talk about how intel_display.c is a giant file and how we would like > to reduce it, so this is my attempt. Currently the file has 12090 lines, and > after my patch series it has 8850 lines. > > I don't know if right now is the appropriate time to merge patches like this. I > don't remember seeing too many patches on the list touching cursor/fdi/eld/pll > functions, but I know there is never an appropriate time for huge changes. > > Also, this change will obviously make the lives of people who backport our > patches more complicated. So if we don't want this series at all, feel free to > NACK it. > > I also didn't really know what kind of changes I needed to do to the file > headers, so I just copied the header from intel_display.c, kept Eric's name and > added a "2014" to Intel's copyright. I am not a lawyer and this may be not the > best thing to do, so please tell me the correct approach here :) > > There are also some things that we might want to migrate from intel_ddi.c to > intel_pll.c, but I'll leave this to another patch. > > Also, feel free to propose better ways to split intel_display.c. FWIW, I think "Authors" lines in headers are silly, now that we're using git. I'd be happy to see mine dropped.
Attachment:
pgpEQtCdAdEy8.pgp
Description: PGP signature
_______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
