On Wed, Apr 09, 2014 at 07:06:14PM +0300, Ville Syrjälä wrote: > On Wed, Apr 09, 2014 at 05:21:47PM +0300, Imre Deak wrote: > > On Wed, 2014-04-09 at 16:15 +0200, Daniel Vetter wrote: > > > On Tue, Apr 08, 2014 at 10:34:41PM +0300, Imre Deak wrote: > > > > v2: > > > > - make it actually compile, I managed to send the wrong version as v1 > > > > somehow > > > > > > > > Signed-off-by: Imre Deak <imre.deak@xxxxxxxxx> > > > > > > Usually if we just want the device to be out of D3 we just use > > > intel_runtime_pm_get/put. On a quick look it seems like that's enough for > > > these places here, too? > > > > For drpc yes, but for the others we need the DPIO power wells up too. I > > got for all VLV case the power well ref for simplicity, I can change it > > to an RPM ref for drpc, if that's ok. > > The dpio_info file would need DPIO wells up. However I think we should > just kill that file. It just dumps a small subset of the registers w/o > decoding anything, and we can get more extensive dumps w/ igt, so I > don't see the point of this file. > > The error handler should already be able to deal with the wells being > down no? > > The gt_cutr_freq file just talks to the punit so no need for any power > wells either AFAICS. I'm ok with this plan of ripping out useless debugfs files. And if we need a specific set of display power domains then imo we should grab the specific list, not just INIT, i.e. all of them. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx