On Wed, 2 Apr 2014 16:36:08 +0100 Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote: > +static void > +i915_gem_stop_ringbuffers(struct drm_device *dev) > +{ > + struct drm_i915_private *dev_priv = dev->dev_private; > + struct intel_ring_buffer *ring; > + int i; > + > + for_each_ring(ring, dev_priv, i) > + intel_cleanup_ring_buffer(ring); > +} > + You've improved the init/alloc ringbuffer naming, but this one confuses me. stop_ringbuffers to me says we're just idling them, but cleanup_ring_buffer actually does the unmap and free right? If so, it looks like this will still tear things down on suspend? Maybe it's all the refactoring making me miss it. :) -- Jesse Barnes, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx