Re: [PATCH] drm/i915: Fix the computation of required fb size for pipe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2 Apr 2014 09:10:44 +0200
Daniel Vetter <daniel@xxxxxxxx> wrote:

> On Wed, Apr 02, 2014 at 07:58:18AM +0100, Chris Wilson wrote:
> > On Thu, Mar 20, 2014 at 03:11:21PM +0000, Chris Wilson wrote:
> > > The computation of required framebuffer size in
> > > 
> > > commit d978ef14456a38034f6c0e94a794129501f89200
> > > Author: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>
> > > Date:   Fri Mar 7 08:57:51 2014 -0800
> > > 
> > >     drm/i915: Wrap the preallocated BIOS framebuffer and preserve for KMS fbcon v12
> > > 
> > > is too optimistic, and would rely on the invariant fb being
> > > reconstructed to exactly fit each pipe (and probably ignore hardware
> > > limits). Instead, we want to compute the upper bound on what the display
> > > engine will access and ensure that is within the inherited framebuffer.
> > > 
> > > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> > > Cc: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>
> > 
> > Ping. The code is just waiting to explode.
> 
> I kinda hoped it would magically get reviewed by Jesse. Thanks for the
> ping, patch is picked up for -fixes.

Yeah sorry my brain exploded when looking at this for the nth time so I
kept putting it off.

Looks fine now though, so belated R-b from me.

-- 
Jesse Barnes, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux