Re: [PATCH 3/3] drm/i915: Implement WaProgramMiArbOnOffAroundMiSetContext:bdw

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 31, 2014 at 06:17:18PM +0300, ville.syrjala@xxxxxxxxxxxxxxx wrote:
> From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> 
> BSpec seems to tell us we need the MI_ARB_ON_OFF w/a around
> MI_SET_CONTEXT on gen8.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>

Reviewed-by: Ben Widawsky <ben@xxxxxxxxxxxx>

> ---
>  drivers/gpu/drm/i915/i915_gem_context.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_gem_context.c b/drivers/gpu/drm/i915/i915_gem_context.c
> index 746fb23..28a2b15 100644
> --- a/drivers/gpu/drm/i915/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/i915_gem_context.c
> @@ -606,8 +606,8 @@ mi_set_context(struct intel_ring_buffer *ring,
>  	if (ret)
>  		return ret;
>  
> -	/* WaProgramMiArbOnOffAroundMiSetContext:ivb,vlv,hsw */
> -	if (IS_GEN7(ring->dev))
> +	/* WaProgramMiArbOnOffAroundMiSetContext:ivb,vlv,hsw,bdw */
> +	if (INTEL_INFO(ring->dev)->gen >= 7)
>  		intel_ring_emit(ring, MI_ARB_ON_OFF | MI_ARB_DISABLE);
>  	else
>  		intel_ring_emit(ring, MI_NOOP);
> @@ -625,7 +625,7 @@ mi_set_context(struct intel_ring_buffer *ring,
>  	 */
>  	intel_ring_emit(ring, MI_NOOP);
>  
> -	if (IS_GEN7(ring->dev))
> +	if (INTEL_INFO(ring->dev)->gen >= 7)
>  		intel_ring_emit(ring, MI_ARB_ON_OFF | MI_ARB_ENABLE);
>  	else
>  		intel_ring_emit(ring, MI_NOOP);
> -- 
> 1.8.3.2
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ben Widawsky, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx





[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux