On Mon, Mar 31, 2014 at 05:18:16PM -0700, Ben Widawsky wrote: > Programming it outside of the rp0-rp1 range is considered a programming > error. Since we do not know that the previous value would actually be in > the range, program something we've read from the hardware, and therefore > know will work. > > This is potentially an issue for platforms whose ranges are outside the > norms given in the programming guide (ie. early silicon) > > v2: Use RP1 instead of RPn > > Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > Signed-off-by: Ben Widawsky <ben@xxxxxxxxxxxx> For my own edification, I read the specs again (because of the RPS fallout) and the VIDEO_FREQ is simply an alternate to the normal boost frequency that we can select either manually or via the pcu for media workloads. We however combine the media workload into overall GPU activity and so only manage the single RPS frequency. Therefore this patch is the right thing to do. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
