[PATCH 7/7] drm/i915: Use enum plane instaad of numbers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>

Change the update_plane() plane checks to use enum plane, and
also fix up the error message to say something that's not total
nonsense.

FIXME killing the checks entirely is probably a better idea

Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
---
 drivers/gpu/drm/i915/intel_display.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index add940c..9a50b64 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -2167,11 +2167,11 @@ static int i9xx_update_primary_plane(struct drm_crtc *crtc,
 	u32 reg;
 
 	switch (plane) {
-	case 0:
-	case 1:
+	case PLANE_A:
+	case PLANE_B:
 		break;
 	default:
-		DRM_ERROR("Can't update plane %c in SAREA\n", plane_name(plane));
+		DRM_ERROR("Can't update plane %c\n", plane_name(plane));
 		return -EINVAL;
 	}
 
@@ -2268,12 +2268,12 @@ static int ironlake_update_primary_plane(struct drm_crtc *crtc,
 	u32 reg;
 
 	switch (plane) {
-	case 0:
-	case 1:
-	case 2:
+	case PLANE_A:
+	case PLANE_B:
+	case PLANE_C:
 		break;
 	default:
-		DRM_ERROR("Can't update plane %c in SAREA\n", plane_name(plane));
+		DRM_ERROR("Can't update plane %c\n", plane_name(plane));
 		return -EINVAL;
 	}
 
-- 
1.8.3.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx





[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux