On Tue, Mar 18, 2014 at 09:09:45AM +0000, Chris Wilson wrote: > On Mon, Mar 17, 2014 at 10:48:46PM -0700, Ben Widawsky wrote: > > Move the remaining members over to the new page table structures. > > > > This can be squashed with the previous commit if desire. The reasoning > > is the same as that patch. I simply felt it is easier to review if split. > > I'm not liking the shorter names much. Is there precedence elsewhere > (e.g. daddr)? > -Chris > I'm not particularly attached to "daddr." It was fun to say in my head. A lot of code does use "daddr" but it seems to vary between "dma", "device", data", "destination" Not exactly precedence. Initially I had the prefix p[td]_daddr, but I thought you might complain about it because it's implicit. dma_addr seemed kinda redundant to me. Recommendation? > -- > Chris Wilson, Intel Open Source Technology Centre > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ben Widawsky, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
