On Sat, Mar 22, 2014 at 03:29:11AM +0000, Gupta, Sourab wrote: > On Fri, 2014-03-21 at 17:18 +0000, Chris Wilson wrote: > > The documentation calls this GFX_MODE bit "Flush TLB invalidate Mode". > > However, that is not a good name for an enable bit as it doesn't make it > > clear what is enabled. An even worse name is GFX_TLB_INVALIDATE_ALWAYS > > as enabling that bit actually prevents the TLB from being invalidated at > > every flush. This leads to great confusion when reading code and > > proposed patches. To get around this try to bake in what is enabled by > > setting the bit and call it GFX_TLB_INVALIDATE_EXPLICIT. > > > > This looks fine. It clears the confusion around TLB INVALIDATE Bit. > We'll be developing our patch on top of this and sending the full series > of WA patches for VLV. btw if you think the patch is useful and you've reviewed it according to the "Reviewer's Statement of Oversight" [1] then please always supply your reviewed-by tag. Otherwise it's just the informal acked-by. Patch merged into dinq. Thanks, Daniel [1] https://www.kernel.org/doc/Documentation/SubmittingPatches -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
