On Wed, Mar 19, 2014 at 8:32 AM, Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> wrote: > On Wed, 19 Mar 2014, Daniel Vetter <daniel@xxxxxxxx> wrote: >> On Tue, Mar 18, 2014 at 01:53:56PM -0700, Siva Chandra wrote: >>> We are testing a few PSR panels; Having a knob to turn PSR on and off >>> would be of great convenience for manual testing and for test scripts. >> >> Is the module param not good enough for that? Iirc we recheck that every >> time ... > > The only thing missing is that changing the module parameter does not > actually change the psr state. So you need to change the parameter and > then cause intel_edp_psr_update to happen. Yes. The module parameter is not active, as in it does not have any effect if we write to its sysfs file. I did consider making the param active. However, since being able to call intel_edp_psr_update requires one to have a handle to the drm_device, we will have to bring in an ugly global. Thanks, Siva Chandra _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
