Re: [PATCH] drm/i915/bdw: Restore PPAT on thaw

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 18, 2014 at 4:09 PM, Ben Widawsky
<benjamin.widawsky@xxxxxxxxx> wrote:
> Apparently it is wiped out from under us, and we get some really fun
> caching artifacts upon resume (it seems to be WB for all types by
> default).
>
> Reported-by: James Ausmus <james.ausmus@xxxxxxxxx>
> Signed-off-by: Ben Widawsky <ben@xxxxxxxxxxxx>

Tested-by: James Ausmus <james.ausmus@xxxxxxxxx>

Works for me backported on to both a 3.14-rc3 w/ ChromeOS sauce and a
vanilla 3.14-rc6. Thanks!

> ---
>  drivers/gpu/drm/i915/i915_gem_gtt.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> index bd016e2..1b45a04 100644
> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> @@ -30,6 +30,8 @@
>  #include "i915_trace.h"
>  #include "intel_drv.h"
>
> +static void gen8_setup_private_ppat(struct drm_i915_private *dev_priv);
> +
>  bool intel_enable_ppgtt(struct drm_device *dev, bool full)
>  {
>         if (i915.enable_ppgtt == 0 || !HAS_ALIASING_PPGTT(dev))
> @@ -1371,8 +1373,10 @@ void i915_gem_restore_gtt_mappings(struct drm_device *dev)
>         }
>
>
> -       if (INTEL_INFO(dev)->gen >= 8)
> +       if (INTEL_INFO(dev)->gen >= 8) {
> +               gen8_setup_private_ppat(dev_priv);
>                 return;
> +       }
>
>         list_for_each_entry(vm, &dev_priv->vm_list, global_link) {
>                 /* TODO: Perhaps it shouldn't be gen6 specific */
> --
> 1.9.0
>



-- 


James Ausmus
Sr. Software Engineer
SSG-OTC ChromeOS Integration
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux