On 03/18/2014 01:29 AM, Chris Wilson wrote: > On Mon, Mar 17, 2014 at 09:27:16AM -0700, Kenneth Graunke wrote: >> Chris, >> >> In the future, if you're going to rewrite significant portions of my >> patches, could you please at least put your Signed-off-by or something >> on it? In the version of "uxa: Enable BLT acceleration on Broadwell.", >> you committed, at least half the patch was not actually written by me, >> and the resulting code either hit assertion failures or GPU hangs if >> run at all. >> >> It's pretty disconcerting to see code committed under my name, with my >> Signed-off-by, that doesn't work and which I've never even seen before. > > I do apologise that you felt I made substantive changes to the patch. As > far I was concerned the addition of the libdrm_intel version bump in > configure (a vital build fix), the change in if-else cascade (cosmetic) > and the only functional change of disabling TexturedVideo for gen8+ were > trivial. > > The fact that the original patch made an assumption that was then broken > by not applying the first patch in the series was not altered by those > changes. And I should have realised that at the time. > -Chris Definitely thanks for those fixes! I should've remembered the libdrm requirement bump. Also, thanks for taking the patches. --Ken
Attachment:
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
