Re: [PATCH 00/23] Merge PC8 with runtime PM, v2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 27, 2014 at 07:26:27PM -0300, Paulo Zanoni wrote:
> From: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx>
> 
> Hi
> 
> This is the second time I send this series to the mailing list. Please read the
> first cover letter:
>    http://lists.freedesktop.org/archives/intel-gfx/2013-December/037721.html
> 
> What's new?
> 
> Two main differences:
>   - Added a patch from Chris, which resulted in a change on how we handle
>     dev_priv->pc8.gpu_busy later.
>   - Fixed a bug on the forcewake handling.
> 
> There is some discussion if we want to merge this first, or the VLV power wells
> patches first. Independently of the decision, I think we should try to at least
> discuss these patches and review what can be reviewed. I really think this
> series should make it easier to add runtime PM support to other platforms, and I
> even added BDW and SNB support on top of these patches.

Looks good. Only too imo minor things:
- Drop the runtime pm get/put from the forcewake get/put functions and
  adjust callers accordingly to grab the runtime pm ref themselves outside
  of the register access. That should fully address Chris'&mine concern in
  that regard. I only expect a minor impact here, if that turns out wrong
  please complain and we need to take another look.

- The aux display power domain patch. Needs acks from platform owners imo,
  I'd just keep it for now.

Also I've merged quite a few patches already, hopefully the most recent
versions. When rebasing pls collect all the r-b tags for speedy merging.

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux