On Tue, 4 Mar 2014 21:08:41 +0100
Daniel Vetter <daniel.vetter@xxxxxxxx> wrote:
> It started as a simple check whether anything is lit up, but now is't
> used to driver the general fallback logic to the default output
> configuration selector in the helper library. So rename it for more
> clarity.
>
> Cc: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>
> Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxx>
> ---
> drivers/gpu/drm/i915/intel_fbdev.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_fbdev.c b/drivers/gpu/drm/i915/intel_fbdev.c
> index 4e4b461e0a70..df00e6b01f0d 100644
> --- a/drivers/gpu/drm/i915/intel_fbdev.c
> +++ b/drivers/gpu/drm/i915/intel_fbdev.c
> @@ -289,7 +289,7 @@ static bool intel_fb_initial_config(struct drm_fb_helper *fb_helper,
> struct drm_device *dev = fb_helper->dev;
> int i, j;
> bool *save_enabled;
> - bool any_enabled = false;
> + bool fallback = true;
>
> /*
> * If the user specified any force options, just bail here
> @@ -347,7 +347,7 @@ static bool intel_fb_initial_config(struct drm_fb_helper *fb_helper,
> */
> for (j = 0; j < fb_helper->connector_count; j++) {
> if (crtcs[j] == new_crtc) {
> - any_enabled = false;
> + fallback = true;
> goto out;
> }
> }
> @@ -390,11 +390,11 @@ static bool intel_fb_initial_config(struct drm_fb_helper *fb_helper,
> encoder->crtc->base.id,
> modes[i]->name);
>
> - any_enabled = true;
> + fallback = false;
> }
>
> out:
> - if (!any_enabled) {
> + if (fallback) {
> memcpy(enabled, save_enabled, dev->mode_config.num_connector);
> kfree(save_enabled);
> return false;
Reviewed-by: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>
--
Jesse Barnes, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
