On Mon, Feb 24, 2014 at 07:17:02PM +0200, Imre Deak wrote: > On Fri, 2014-02-21 at 13:06 -0800, Ben Widawsky wrote: > > With the original PPGTT implementation if the number of PDPs was not a > > power of two, the number of pages for the page tables would end up being > > rounded up. The code actually had a bug here afaict, but this is a > > theoretical bug as I don't believe this can actually occur with the > > current code/HW.. > > > > With the rework of the page table allocations, there is no longer a > > distinction between number of page table pages, and number of page > > directory entries. To avoid confusion, kill the redundant (and newer) > > struct member. > > > > Cc: Imre Deak <imre.deak@xxxxxxxxx> > > Signed-off-by: Ben Widawsky <ben@xxxxxxxxxxxx> > > Nitpick: keeping num_pt_pages instead would make the code more > understandable to me and symmetric with num_pd_pages, but that would've > been much more churn. In any case nice simplification, > > Reviewed-by: Imre Deak <imre.deak@xxxxxxxxx> All merged to dinq, thanks for patches&review. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
