Re: [PATCH] drm/i915: Don't just say it, actually force edp vdd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 04, 2014 at 12:42:44AM +0100, Patrik Jakobsson wrote:
> This patch fixes the blank screen bug introduced in 3.14-rc1 on the
> MacBook Air 6,2. The comments state that we need to force edp vdd so
> lets put it back.
> 
> The regression was introduced by the following commit:
> 
> commit dff392dbd258381a6c3164f38420593f2d291e3b
> Author: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx>
> Date:   Fri Dec 6 17:32:41 2013 -0200
> 
>     drm/i915: don't touch the VDD when disabling the panel
> 
> v2: Wrap intel_disable_dp() with _vdd_on and _vdd_off
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=74628
> Cc: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx>
> Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Patrik Jakobsson <patrik.r.jakobsson@xxxxxxxxx>

This brings the code into line with the comments, and has the bonus of
working on a fiddly panel, so

Acked-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>

I don't feel confident enough with the DP sequencing to say why it has
to be so though.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux