Update the comment about trying suid-root first with some explanations of why pkexec may be preferable in some cases. Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> --- src/backlight.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/backlight.c b/src/backlight.c index 70c6559..0e63ba5 100644 --- a/src/backlight.c +++ b/src/backlight.c @@ -270,8 +270,10 @@ static int __backlight_helper_init(struct backlight *b, char *iface) int use_pkexec = 0; int fds[2]; - /* If system policy is to disallow setuid helpers, - * we fallback to invoking PolicyKit. However, as pkexec + /* + * Some systems may prefer using PolicyKit's pkexec over + * making the helper suid root, since the suid option will allow + * anyone to control the backlight. However, as pkexec * is quite troublesome and not universally available, we * still try the old fashioned and simple method first. * Either way, we have to trust that it is our backlight-helper -- 1.8.5.3 _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
