On Wed, Feb 12, 2014 at 02:28:52PM -0800, Ben Widawsky wrote: > Simply to match the GEN8 style of PPGTT initialization, split up the > allocations and mappings. Unlike GEN8, we skip a separate dma_addr_t > allocation function, as it is much simpler pre-gen8. > > With this code it would be easy to make a more general PPGTT > initialization function with per GEN alloc/map/etc. or use a common > helper, similar to the ringbuffer code. I don't see a benefit to doing > this just yet, but who knows... > > Signed-off-by: Ben Widawsky <ben@xxxxxxxxxxxx> Had to double-check whether free_pages() safely accepted NULL, but that was the only logic change I spotted, so Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx