On Wed, Feb 12, 2014 at 07:31:16PM +0200, Imre Deak wrote: > On Wed, 2014-02-12 at 17:55 +0100, Daniel Vetter wrote: > > Just a bit of polish which I hope will help me with massaging some > > internal patches to use Imre's reworked pipestat handling: > > - Don't check for underrun reporting or enable pipestat interrupts > > twice. > > - Frob the comments a bit. > > - Do the iir PIPE_EVENT to pipe mapping explicitly with a switch. We > > only have one place which does this, so better to make it explicit. > > > > v2: Ville noticed that I've broken the logic a bit with trying to > > avoid checking whether we're interested in a given pipe twice. push > > the PIPESTAT read down after we've computed the mask of interesting > > bits first to avoid that duplication properly. > > > > Cc: Imre Deak <imre.deak@xxxxxxxxx> > > Cc: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxx> > > Looks simpler, so: > Reviewed-by: Imre Deak <imre.deak@xxxxxxxxx> Queued for -next, thanks for the review. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
