On Wed, Jan 29, 2014 at 9:55 AM, Ben Widawsky
<benjamin.widawsky@xxxxxxxxx <mailto:benjamin.widawsky@xxxxxxxxx>> wrote: It wasn't ever used by the caller anyway with the exception of what we show in sysfs. Signed-off-by: Ben Widawsky <ben@xxxxxxxxxxxx <mailto:ben@xxxxxxxxxxxx>> --- drivers/gpu/drm/i915/intel_pm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index bcbdac2..258241b 100644 --- a/drivers/gpu/drm/i915/intel_pm.c +++ b/drivers/gpu/drm/i915/intel_pm.c @@ -3161,7 +3161,7 @@ int intel_enable_rc6(const struct drm_device *dev) if (INTEL_INFO(dev)->gen == 5) return 0; - if (IS_IVYBRIDGE(dev) || IS_VALLEYVIEW(dev)) + if (IS_IVYBRIDGE(dev)) return (INTEL_RC6_ENABLE | INTEL_RC6p_ENABLE); else return INTEL_RC6_ENABLE; -- 1.8.5.3 _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx <mailto:Intel-gfx@xxxxxxxxxxxxxxxxxxxxx> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
I think, we can avoid else condition and return INTEL_RC6_ENABLE if the other platform checks fails?
Reviewed-by: Deepak S <deepak.s@xxxxxxxxx> _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx