On Tue, 2014-02-04 at 11:25 +0000, Damien Lespiau wrote: > On Tue, Feb 04, 2014 at 12:18:24PM +0100, Daniel Vetter wrote: > > On Sat, Feb 01, 2014 at 12:43:48AM +0530, sagar.a.kamble@xxxxxxxxx wrote: > > > From: Sagar Kamble <sagar.a.kamble@xxxxxxxxx> > > > > > > This test will verify the 180 degree rotation of sprite and crtc planes. > > > It will allow user to control rotation separately for crtc and sprite > > > planes. > > > > > > Signed-off-by: Sagar Kamble <sagar.a.kamble@xxxxxxxxx> > > > > What I actually want for upstreaming is a fully automated testcase as part > > of our i-g-t testsuite which uses the CRC support. Having testing tools > > for developers is neat, but if it's not automated it's essentially > > untested. > > > > I don't mind merging this if there's someone else who'll ack it though. > > While having such a tool helps development for sure, let's try to take a > better approach on this. > > I'm currently reworking how we write display tests to not have 1000 > lines code to setup the display pipeline in every test, leave me a few > days and we should be in a much better place to write kms tests. Of > course, we also really want a CRC enabled test. > I am trying to enable CRC approach for this test however I have following opens: 1. How do I calculate CRC for reference image(blend of primary and overlay planes) prepared by i-g-t test. 2. Will this CRC result match the pipe CRC calculated by display pipe for the blend output. 3. Will plane based CRC check suffice for these tests as of now given above two opens? thanks, Sagar _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
