Re: [PATCH v2 1/4] drm/i915: Use i915_hw_context to set reset stats

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 30, 2014 at 04:01:15PM +0200, Mika Kuoppala wrote:
> With full ppgtt support drm_i915_file_private gained knowledge
> about the default context. Also reset stats are now inside
> i915_hw_context so we can use proper abstraction.
> 
> v2: Move BUG_ON and WARN_ON to more proper locations (Ben)
> 
> Suggested-by: Ben Widawsky <ben@xxxxxxxxxxxx>
> Signed-off-by: Mika Kuoppala <mika.kuoppala@xxxxxxxxx>
> Reviewed-by: Ben Widawsky <ben@xxxxxxxxxxxx>

[snip]

> +	BUG_ON(!ctx->last_ring);

I've changed this to a WARN_ON - killing the entire driver over this seems
a bit excessive.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux