On Mon, Jan 27, 2014 at 09:47:12PM +0000, Chris Wilson wrote: > On Mon, Jan 27, 2014 at 07:10:51PM +0100, Daniel Vetter wrote: > > Anything more than just one bool parameter is just a pain to read, > > symbolic constants are much better. > > This patch introduces PIN_GLOBAL which is required for ggtt_pin to > remain correct with the flag changes in the later patches, but > PIN_GLOBAL is only implemented in the final patch, patch 9. Indeed I've fumbled this. Will reshuffle. The entire global/ppgtt pin stuff is fairly messy in the current code anyway, dunno whether we can do better. The code as-is just feels like it's hiding things a bit ... -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
