On Sun, Jan 26, 2014 at 03:33:32PM +0100, Daniel Vetter wrote: > On Sat, Jan 25, 2014 at 08:59:49PM +0100, Daniel Vetter wrote: > > On Thu, Jan 23, 2014 at 07:47:59PM +0000, Chris Wilson wrote: > > > On Thu, Jan 23, 2014 at 04:49:07PM +0200, ville.syrjala@xxxxxxxxxxxxxxx wrote: > > > > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > > > > > > > Since fixing the FBC locking is a bigger task that will take a while, > > > > I decided to pull all the simple fixes from my branch and post them > > > > right away. > > > > > > > > Some of these I've posted before, some others have seen a bit of action > > > > by being in a public branch. > > > > > > > > The FBC_FENCE_OFF change is just a guess at this point. The odd offset > > > > just caught my eye while reading throguh i915_reg.h. > > > > > > I didn't spot anything offensive in the series and each patch only does > > > what it says on the tin. So I am going to stick my neck out and say > > > > > > Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > > > > > > for the series. Being picky, I guess Fix FBC_FENCE_OFF should only be an > > > acked-by since we have no way to review it... > > > > Entire series merged, and I'll fire up my g4x here to see what happens ;-) > > Hm, seems to fail on my g4x when I enable fbc. This is on latest -nightly: Also, shouldn't we enable fbc now on all gen5+ machines? Or is there still something outstanding to fix issues? Atm we only have it enabled on haswell :( -Daniel > > > > IGT-Version: 1.5-gb5109e62cea1 (x86_64) (Linux: 3.13.0-rc8+ x86_64) > Subtest bad-pipe: SUCCESS > Subtest bad-source: SUCCESS > Subtest bad-nb-words-1: SUCCESS > Subtest bad-nb-words-3: SUCCESS > read-crc-pipe-A: Testing connector 5 > Subtest read-crc-pipe-A: SUCCESS > read-crc-pipe-A-frame-sequence: Testing connector 5 > Subtest read-crc-pipe-A-frame-sequence: SUCCESS > read-crc-pipe-B: Testing connector 5 > Subtest read-crc-pipe-B: SUCCESS > read-crc-pipe-B-frame-sequence: Testing connector 5 > Subtest read-crc-pipe-B-frame-sequence: SUCCESS > Test requirement not met in function test_read_crc, file kms_pipe_crc_basic.c:210: > Last errno: 0, Success > Test requirement: (!(valid_connectors)) > No connector found for pipe 2 > Subtest read-crc-pipe-C: SKIP > Test requirement not met in function test_read_crc, file kms_pipe_crc_basic.c:210: > Last errno: 0, Success > Test requirement: (!(valid_connectors)) > No connector found for pipe 2 > Subtest read-crc-pipe-C-frame-sequence: SKIP > root@gina:/home/daniel/xorg/intel-gpu-tools# tests/kms_fbc_crc > IGT-Version: 1.5-gb5109e62cea1 (x86_64) (Linux: 3.13.0-rc8+ x86_64) > Beginning page_flip on crtc 3, connector 5 > > page_flip on crtc 3, connector 5: PASSED > > Beginning page_flip on crtc 4, connector 5 > > page_flip on crtc 4, connector 5: PASSED > > Subtest page_flip: SUCCESS > Beginning mmap_cpu on crtc 3, connector 5 > > mmap_cpu on crtc 3, connector 5: PASSED > > Beginning mmap_cpu on crtc 4, connector 5 > > mmap_cpu on crtc 4, connector 5: PASSED > > Subtest mmap_cpu: SUCCESS > Beginning mmap_gtt on crtc 3, connector 5 > > mmap_gtt on crtc 3, connector 5: PASSED > > Beginning mmap_gtt on crtc 4, connector 5 > > mmap_gtt on crtc 4, connector 5: PASSED > > Subtest mmap_gtt: SUCCESS > Beginning blt on crtc 3, connector 5 > > blt on crtc 3, connector 5: PASSED > > Beginning blt on crtc 4, connector 5 > > blt on crtc 4, connector 5: PASSED > > Subtest blt: SUCCESS > Beginning render on crtc 3, connector 5 > Test requirement not met in function fill_render, file kms_fbc_crc.c:212: > Last errno: 0, Success > Test requirement: (!rendercopy) > Subtest render: SKIP > Test requirement not met in function prepare_crtc, file kms_fbc_crc.c:398: > Last errno: 19, No such device > Test requirement: (!(data->ctx[0])) > Subtest context: SKIP > Beginning page_flip_and_mmap_cpu on crtc 3, connector 5 > Test assertion failure function test_crc, file kms_fbc_crc.c:315: > Last errno: 0, Success > Failed assertion: !igt_crc_equal(&crcs[0], &data->ref_crc[1]) > Subtest page_flip_and_mmap_cpu: FAIL > Beginning page_flip_and_mmap_gtt on crtc 3, connector 5 > Test assertion failure function test_crc, file kms_fbc_crc.c:315: > Last errno: 0, Success > Failed assertion: !igt_crc_equal(&crcs[0], &data->ref_crc[1]) > Subtest page_flip_and_mmap_gtt: FAIL > Beginning page_flip_and_blt on crtc 3, connector 5 > > page_flip_and_blt on crtc 3, connector 5: PASSED > > Beginning page_flip_and_blt on crtc 4, connector 5 > > page_flip_and_blt on crtc 4, connector 5: PASSED > > Subtest page_flip_and_blt: SUCCESS > Beginning page_flip_and_render on crtc 3, connector 5 > Test requirement not met in function fill_render, file kms_fbc_crc.c:212: > Last errno: 0, Success > Test requirement: (!rendercopy) > Subtest page_flip_and_render: SKIP > Test requirement not met in function prepare_crtc, file kms_fbc_crc.c:398: > Last errno: 19, No such device > Test requirement: (!(data->ctx[0])) > Subtest page_flip_and_context: SKIP > > So something with flip + frontbuffer access seems still busted. > -Daniel > -- > Daniel Vetter > Software Engineer, Intel Corporation > +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
