On Tue, Jan 21, 2014 at 09:44:51PM +0000, Damien Lespiau wrote: > We try to put display related things into intel_drv.h, it was in > i915_drv.h because it was in debugfs.c. Also intel_drv.h and i915_drv.h > are neatly separated by file, so it'd be nice to have a separate entry > for intel_display_test.c. Also, there's another chunk in i915_drv.h you may want to move to intel_drv.h if you decide the OCD is justifed: #ifdef CONFIG_DEBUG_FS void intel_display_crc_init(struct drm_device *dev); #else static inline void intel_display_crc_init(struct drm_device *dev) {} #endif -- Damien _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx