Re: [PATCH 2/4] drm/i915: Factor out a function returning the AUX_CTL value to start a send

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 21, 2014 at 12:07:23PM +0200, Jani Nikula wrote:
> 
> On Mon, 20 Jan 2014, Damien Lespiau <damien.lespiau@xxxxxxxxx> wrote:
> > Also, move that computation outside of the for loop that tries 5 times,
> > this value doesn't change between tries.
> 
> Some general bikeshedding...
> 
> I really wish everyone would write commit messages that work independent
> of the patch subject. Just like a newspaper article should make sense
> and tell a story also in the absence of a headline.

Will keep this in mind next time (one could argue we're in deep
bikeshedding water here!).

-- 
Damien
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux