On Wed, Jan 08, 2014 at 05:14:43PM +0100, Daniel Vetter wrote: > On Wed, Jan 08, 2014 at 03:38:43PM +0000, Chris Wilson wrote: > > On Wed, Jan 08, 2014 at 04:19:06PM +0100, Daniel Vetter wrote: > > > A regression in the topic/ppgtt branch introduce in > > > > > > commit 87d60b63e0371529faaed0667d457e5022964010 > > > Author: Ben Widawsky <ben@xxxxxxxxxxxx> > > > Date: Fri Dec 6 14:11:29 2013 -0800 > > > > > > drm/i915: Add PPGTT dumper > > > > I'm missing some context, what's the actual regression? Without debugfs > > the code will not be called and it just wastes a small amount of kernel > > memory, and seq_file should still be valid. > > We don't include the respective headers for seq_printf, so compilation > fails. Very sloppy commit message from my side, I'll amend when merging. > Not sure whether the #ifdef'ery is really worth it though ... I'd take an extra header include than ifdefs in the code any day. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
