On Dec-20-2013 7:35 PM, Daniel Vetter wrote: > On Fri, Dec 20, 2013 at 1:29 PM, Jani Nikula > <jani.nikula@xxxxxxxxxxxxxxx> wrote: >>> Signed-off-by: Pradeep Bhat <pradeep.bhat@xxxxxxxxx> >>> Signed-off-by: Vandana Kannan <vandana.kannan@xxxxxxxxx> >>> Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx> >>> Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> >>> Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> >> >> I'm sorry, this is not true. Only I get to say when you can add my >> Reviewed-by. > > Yeah, you can't just add review-by comments. In the linux kernel this > has a very specific meaning and can't just get handed out for "has > looked at the patches". For details of what a reviewed-by tag means > please see the "Reviewer's statement of oversight" in > Documentation/SubmittingPatches. I've noticed that you've also done > this with Ville's r-b tag for the picture ratio patch, I'll send out a > note that this r-b isn't legit. > -Daniel > Thanks for your inputs. I will remove the r-b tag from all DRRS related patches, keeping the details of versions/review comments incorporated in the commit message. Also, I will follow the same and resend the patch on picture aspect ratio. - Vandana _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
