On Dec-18-2013 2:54 PM, Daniel Vetter wrote: > On Tue, Dec 17, 2013 at 10:58:22AM +0530, Vandana Kannan wrote: >> Dynamic Refresh Rate Switching (DRRS) is a power conservation feature which >> enables switching between low and high refresh rates based on the usage >> scenario. This feature is applicable for internal eDP panel. Indication that >> the panel can support DRRS is given by the panel EDID, which would list >> multiple refresh rates for one resolution. >> The patch series supports idleness detection in display i915 driver and switch >> to low refresh rate. > > Just one overall comment on process: > > When resending patches _always_ mention what you've changed compared to > the last version. Specifically call out which review comments you've > incorporated and even more important which one's you've decided to > implement differently or rejected. > > The preferred form for that is with a per-patch changelog in the commit > message. Also mentioned the reviewer's name if the change is due to > review. > > For bigger reworks that affect the entire patch series please also mention > them in the cover letter. > > I'll update our internal BKMs with this information. > > Thanks, Daniel Thanks Daniel. I will incorporate these comments while resending the patches. - Vandana >> >> Pradeep Bhat (3): >> drm/i915: Adding VBT fields to support eDP DRRS feature >> drm/i915: Parse EDID probed modes for DRRS support >> drm/i915: Add support for DRRS to switch RR >> >> Vandana Kannan (2): >> drm/i915: Idleness detection for DRRS >> drm/i915/bdw: Add support for DRRS to switch RR >> >> drivers/gpu/drm/i915/i915_drv.h | 30 ++++++ >> drivers/gpu/drm/i915/i915_reg.h | 1 + >> drivers/gpu/drm/i915/intel_bios.c | 23 +++++ >> drivers/gpu/drm/i915/intel_bios.h | 29 ++++++ >> drivers/gpu/drm/i915/intel_display.c | 13 +++ >> drivers/gpu/drm/i915/intel_dp.c | 180 ++++++++++++++++++++++++++++++++++ >> drivers/gpu/drm/i915/intel_drv.h | 35 ++++++- >> drivers/gpu/drm/i915/intel_pm.c | 112 +++++++++++++++++++++ >> drivers/gpu/drm/i915/intel_sprite.c | 3 + >> 9 files changed, 425 insertions(+), 1 deletion(-) >> >> -- >> 1.7.9.5 >> >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx >> http://lists.freedesktop.org/mailman/listinfo/intel-gfx > _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
