On Sat, Dec 14, 2013 at 05:48:08PM -0800, Ben Widawsky wrote: > On Sat, Dec 14, 2013 at 09:38:57PM +0000, Chris Wilson wrote: > > Capturing the semaphore_obj itself looks a bit silly since we never do > > dump it into i915_error_state, but I actually like how you've reading back of > > the semaphore page for debugging hangs. > > I don't understand this comment. The semaphore page is dumped, though I > snipped that, so maybe that's why you made the comment. It's added to the error state, but not printed out by i915_gpu_error or freed, afaict. So the capture is just a convenient method to read back the page and not used afterwards. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
