Re: [PATCH 09/17] drm/i915: init ring->id early

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 13, 2013 at 08:15:57PM -0800, Ben Widawsky wrote:
> Having the ring id all set up will allow us to use some macro shortcuts
> during ringbuffer init. Admittedly it leaves the code a bit confusing,
> having the initialization of the id member in a separate place - but I
> think the savings is worth it.

This is not required since the macro could be written more simply as
ring[i]->id == i.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux