On Thu, Dec 12, 2013 at 11:17:39AM -0200, Paulo Zanoni wrote: > 2013/12/12 Damien Lespiau <damien.lespiau@xxxxxxxxx>: > > On Mon, Nov 25, 2013 at 03:27:08PM -0200, Paulo Zanoni wrote: > >> From: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx> > >> > >> The first piece, intel_ddi_pll_select, finds a PLL and assigns it to > >> the CRTC, but doesn't write any register. It can also fail in case it > >> doesn't find a PLL. > >> > >> The second piece, intel_ddi_pll_enable, uses the information stored by > >> intel_ddi_pll_select to actually enable the PLL by writing to its > >> register. This function can't fail. We also have some refcount sanity > >> checks here. > >> > >> The idea is that one day we'll remove all the functions that touch > >> registers from haswell_crtc_mode_set to haswell_crtc_enable, so we'll > >> call intel_ddi_pll_select at haswell_crtc_mode_set and then call > >> intel_ddi_pll_enable at haswell_crtc_enable. Since I'm already > >> touching this code, let's take care of this particular split today. > >> > >> v2: - Clock on the debug message is in KHz > >> - Add missing POSTING_READ > >> > >> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx> > > > > > > Reviewed-by: Damien Lespiau <damien.lespiau@xxxxxxxxx> > > > > /* > > * As a side note, CodingStyle stipulates this is the preferred style > > * for multi-line comments. Really a small detail to keep in my in the > > * future :) > > */ > > I know, but our internal documentation says that "Multi-line comment > delimiters (i.e. /* and */) do not need to be on empty lines.", so I > was following this recommendation. Documentation is now fixed (and also comments updated in the patch). > Thanks for the review! Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
