Re: [PATCH 1/3] tests: drm_open_any doesn't fail

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 06, 2013 at 10:48:42AM +0100, Daniel Vetter wrote:
> Or more precisely: It already has an igt_require. So we cant ditch it
> from tests.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxx>

Reviewed-by: Damien Lespiau <damien.lespiau@xxxxxxxxx>

> ---
>  tests/kms_cursor_crc.c     | 1 -
>  tests/kms_fbc_crc.c        | 1 -
>  tests/kms_pipe_crc_basic.c | 1 -
>  3 files changed, 3 deletions(-)
> 
> diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c
> index 74da32eb7497..b78ea7863585 100644
> --- a/tests/kms_cursor_crc.c
> +++ b/tests/kms_cursor_crc.c
> @@ -338,7 +338,6 @@ igt_main
>  		const char *cmd = "pipe A none";
>  
>  		data.drm_fd = drm_open_any();
> -		igt_require(data.drm_fd >= 0);
>  
>  		igt_set_vt_graphics_mode();
>  
> diff --git a/tests/kms_fbc_crc.c b/tests/kms_fbc_crc.c
> index 660086290f28..7a7f3903667b 100644
> --- a/tests/kms_fbc_crc.c
> +++ b/tests/kms_fbc_crc.c
> @@ -492,7 +492,6 @@ igt_main
>  		FILE *status;
>  
>  		data.drm_fd = drm_open_any();
> -		igt_require(data.drm_fd);
>  		igt_set_vt_graphics_mode();
>  
>  		data.devid = intel_get_drm_devid(data.drm_fd);
> diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c
> index 3bc9eb0ee361..0e793cdf617d 100644
> --- a/tests/kms_pipe_crc_basic.c
> +++ b/tests/kms_pipe_crc_basic.c
> @@ -219,7 +219,6 @@ igt_main
>  		const char *cmd = "pipe A none";
>  
>  		data.drm_fd = drm_open_any();
> -		igt_require(data.drm_fd >= 0);
>  
>  		igt_set_vt_graphics_mode();
>  
> -- 
> 1.8.4.3
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux