Thanks Daniel. -----Original Message----- From: Daniel Vetter [mailto:daniel.vetter@xxxxxxxx] On Behalf Of Daniel Vetter Sent: Wednesday, November 27, 2013 9:30 PM To: S, Deepak Cc: Jesse Barnes; intel-gfx@xxxxxxxxxxxxxxxxxxxxx Subject: Re: [PATCH 3/3] drm/i915: Enabling DebugFS for valleyview forcewake counts On Tue, Nov 26, 2013 at 10:12:48AM +0000, S, Deepak wrote: > Yes Jesse, this is a warning fix. Yeah, those should be separate or at least mentioned in the commit message. But I have this one already so it naturally dropped out. All three patches merged to dinq, thanks. -Daniel > > -----Original Message----- > From: Jesse Barnes [mailto:jbarnes@xxxxxxxxxxxxxxxx] > Sent: Monday, November 25, 2013 10:09 PM > To: S, Deepak > Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH 3/3] drm/i915: Enabling DebugFS for > valleyview forcewake counts > > On Sat, 23 Nov 2013 14:55:44 +0530 > deepak.s@xxxxxxxxx wrote: > > @@ -2349,7 +2357,7 @@ static int pipe_crc_set_source(struct > > drm_device *dev, enum pipe pipe, { > > struct drm_i915_private *dev_priv = dev->dev_private; > > struct intel_pipe_crc *pipe_crc = &dev_priv->pipe_crc[pipe]; > > - u32 val; > > + u32 val = 0; > > int ret; > > > > if (pipe_crc->source == source) > > Spurious warning fix? Otherwise looks fine. > > Reviewed-by: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx> > > -- > Jesse Barnes, Intel Open Source Technology Center > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
