On Thu, Nov 21, 2013 at 11:20:58PM +0000, Chris Wilson wrote: > On Thu, Nov 21, 2013 at 09:29:53PM +0200, ville.syrjala@xxxxxxxxxxxxxxx wrote: > > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > > > Flush the caches when moving a scanout buffer from CPU to GTT domain. > > This allows us to move a scanout buffer to CPU write domain, do some > > writes, and move it back to the GTT read domain. The display will then > > see the correct data. In addition we still need to do the dirtyfb > > ioctl to nuke FBC if that's enabled. > > > > Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> Isn't this what sw_finish is for? > > But we could actually rework flush_cpu_write_domain to drop the force > parameter now that we have obj->pin_display. Although it doesn't really fit into the new world any longer ... -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
