On Wed, Nov 20, 2013 at 3:03 AM, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote:
> On Tue, Nov 19, 2013 at 09:37:16AM -0800, Rodrigo Vivi wrote:
>> On Tue, Nov 19, 2013 at 5:52 AM, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote:
>> > On Mon, Nov 18, 2013 at 06:32:34PM -0800, Rodrigo Vivi wrote:
>> >> From: Daniel Vetter <daniel.vetter@xxxxxxxx>
>> >>
>> >> This is useful when we only have aliasing ppgtt and want to figure out
>> >> what exactly is accesssible and what not. Paulo can somehow overwrite
>> >> the fbcon framebuffer with the blitter on his hsw machine ...
>> >>
>> >> v2: Actually make it compile.
>> >>
>> >> Cc: Paulo Zanoni <przanoni@xxxxxxxxx>
>> >> Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxx>
>> >> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>
>> >
>> > This is still too ugly.
>>
>> at least should be the opposite pp before g and complemented with a tt
>> in the end.
>>
>> >
>> > (bindings: )
>> > (bindings: g)
>> > (bindings: pp)
>> > (bindings: gpp)
>> > -Chris
>>
>> But what are all real possible options?
>>
>> nothing, gtt or ppgtt?
>
> nothing, gtt, ppggt, both.
so, forget what I said...
what about this below?
seq_printf(m, " (bindings: %s%s)",
obj->has_global_gtt_mapping ? "gtt" : "",
obj->has_aliasing_ppgtt_mapping ? " ppgtt" : "");
(bindings: )
(bindings: gtt)
(bindings: ppgtt)
(bindings: gtt ppgtt)
with or without this bikeshed feel free to use:
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>
> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre
--
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
