On Thu, 14 Nov 2013 19:02:15 +0530
deepak.s@xxxxxxxxx wrote:
> From: Deepak S <deepak.s@xxxxxxxxx>
>
> Added media/render/common well VLV force wake routines to help
> bring up the WELLS before access the register
> - Refactor current vlv_forcewake get/put and added MEDIA or
> RENDER specific Forcewake.
> - Added VLV Check to bring up MEDIA and RENDER WELL base
> on the register accessed in vlv_read##x (in intel_uncore.c)
This patch is pretty big and so a bit hard to review. A couple of
questions:
- why not use the callback to __vlv_force_wake_* from
gen6_gt_force_wake_*? i.e. why is VLV special here?
- having a new gen7_media_force_wake function may be better than
passing an engine around, and would touch fewer pieces of code
- have you done measurements on this? given how infrequently we
ought to be waking the wells when they're idle, and how long we
generally keep them awake, is this a real power win?
Thanks,
Jesse
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
