Re: [PATCH 10/23] piglit: Run our test suite with --no-concurrency

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 15, 2013 at 04:33:27PM +0000, Damien Lespiau wrote:
> Tests tend to assume they are the only thing running, some need DRM
> master, some fill the memory. All in all, they are some correctness
> issues if we run tests concurrently.
> 
> Acked-by: Ben Widawsky <ben@xxxxxxxxxxxx>
> Signed-off-by: Damien Lespiau <damien.lespiau@xxxxxxxxx>

Concurrency is a per-test opt-in thing in piglit. So this is cargo-cult
and worse will prevent us to run a subset of tests to run in parallel
(e.g. once we have a naming scheme for abi stuff).
-Daniel

> ---
>  Makefile.am | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile.am b/Makefile.am
> index 5742b82..f280879 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -50,7 +50,7 @@ dist-hook: ChangeLog INSTALL
>  #
>  # Useful shortcuts to run tests
>  #
> -PIGLIT := $(srcdir)/piglit/piglit-run.py
> +PIGLIT := $(srcdir)/piglit/piglit-run.py --no-concurrency
>  PIGLIT_SUMMARY := $(srcdir)/piglit/piglit-summary.py -s
>  PIGLIT_HTML := $(srcdir)/piglit/piglit-summary-html.py
>  IGT_TESTS := $(abs_srcdir)/piglit/tests/igt.tests
> -- 
> 1.8.3.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux