[PATCH 00/13] drm/i915: backlight rewrite

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi all -

This series is a successor to [1], but with too many changes to list so
I'll just consider this v1 of the patches.

This is pretty much a rewrite of our backlight code. Highlights:

* All the platform specific stuff in platform specific functions. The
  code is much easier to follow, and it will be easier to enable future
  platforms without breaking old ones all the time.

* Backlight enable writes all the backlight registers based on
  information retrieved at setup stage. We no longer depend on what's in
  the registers prior to enable, which should make things more
  deterministic, and we no longer need to save/restore backlight
  registers.

* We no longer keep reading max backlight value or combination mode bits
  etc. from the registers all over the place. All that is based on the
  initial values read in the setup stage.

TODO:

* If initial setup in registers is bogus, we should try to read the
  values from VBT and/or try to use sane defaults. (This problem we have
  already, not introduced by the series.)

I've tested this so far on ILK and IVB, trying carefully keep it working
commit by commit to keep things bisectable. More testing across
platforms is very much needed. We have a history with backlight...

Also available at backlight-rework branch at [2].


BR,
Jani.


[1] http://mid.gmane.org/cover.1383237868.git.jani.nikula@xxxxxxxxx
[2] git://gitorious.org/jani/drm.git


Jani Nikula (13):
  drm/i915: clean up backlight conditional build
  drm/i915: make backlight info per-connector
  drm/i915: make asle notifications update backlight on all connectors
  drm/i915: handle backlight through chip specific functions
  drm/i915: fix gen2-gen3 backlight set
  drm/i915: vlv does not have pipe field in backlight registers
  drm/i915: move backlight level setting in enable/disable to hooks
  drm/i915: use the initialized backlight max value instead of reading
    it
  drm/i915: debug print on backlight register
  drm/i915: gather backlight information at setup
  drm/i915: do full backlight setup at enable time
  drm/i915: nuke get max backlight functions
  drm/i915: do not save/restore backlight registers

 drivers/gpu/drm/i915/i915_dma.c       |    2 +-
 drivers/gpu/drm/i915/i915_drv.h       |   23 +-
 drivers/gpu/drm/i915/i915_suspend.c   |   45 --
 drivers/gpu/drm/i915/intel_display.c  |   11 +-
 drivers/gpu/drm/i915/intel_drv.h      |   14 +-
 drivers/gpu/drm/i915/intel_opregion.c |   43 +-
 drivers/gpu/drm/i915/intel_panel.c    |  819 +++++++++++++++++++++------------
 7 files changed, 566 insertions(+), 391 deletions(-)

-- 
1.7.10.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux