On Thu, Nov 07, 2013 at 09:40:44PM -0800, Ben Widawsky wrote: > Many GENs generally perform the same actions just on different > registers. This is true going forward as well. To ease the transition a > bit, extract the common code where possible. > > Signed-off-by: Ben Widawsky <ben@xxxxxxxxxxxx> As explained on internal irc I'm rather reluctant to pull in refactoring patches into -fixes just for bdw enabling. Especially for fragile code like the backlight. So I'd just go with adding a copy-pasted version of set/get/enable for broadwell. That should also fit in with Jani's plans for 3.14 with the complete backlight refactoring. Adding Jani so he can explain what he'd like. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx