Re: [PATCH 2/2] drm/i915/vlv: For i915_cur_delayinfo, the max frequency reporting wrong value.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu,  7 Nov 2013 15:23:27 +0800
Chon Ming Lee <chon.ming.lee@xxxxxxxxx> wrote:

> The max frequency reporting is not correct.  But there is already an existing
> valleyview_rps_max_freq and valleyview_rps_min_freq to get the
> frequency.  Use that for i915_cur_delayinfo.
> 
> Signed-off-by: Chon Ming Lee <chon.ming.lee@xxxxxxxxx>
> ---
>  drivers/gpu/drm/i915/i915_debugfs.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index cae3e9c..5254d95 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -972,11 +972,11 @@ static int i915_cur_delayinfo(struct seq_file *m, void *unused)
>  		seq_printf(m, "PUNIT_REG_GPU_FREQ_STS: 0x%08x\n", freq_sts);
>  		seq_printf(m, "DDR freq: %d MHz\n", dev_priv->mem_freq);
>  
> -		val = vlv_punit_read(dev_priv, PUNIT_FUSE_BUS1);
> +		val = valleyview_rps_max_freq(dev_priv);
>  		seq_printf(m, "max GPU freq: %d MHz\n",
>  			   vlv_gpu_freq(dev_priv->mem_freq, val));
>  
> -		val = vlv_punit_read(dev_priv, PUNIT_REG_GPU_LFM);
> +		val = valleyview_rps_min_freq(dev_priv);
>  		seq_printf(m, "min GPU freq: %d MHz\n",
>  			   vlv_gpu_freq(dev_priv->mem_freq, val));
>  

Ok yeah this is just ancient.  It never got fixed up when the other
bits were added.

Reviewed-by: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>

-- 
Jesse Barnes, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux