✗ Fi.CI.CHECKPATCH: warning for Fix i915 pmu on bind/unbind (rev2)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



== Series Details ==

Series: Fix i915 pmu on bind/unbind (rev2)
URL   : https://patchwork.freedesktop.org/series/136362/
State : warning

== Summary ==

Error: dim checkpatch failed
73e46040952e squashed series - 20241008183501.1354695-1-lucas.demarchi@xxxxxxxxx
-:7: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#7: 
Patches 2 and 3 of https://lore.kernel.org/all/20241008183501.1354695-1-lucas.demarchi@xxxxxxxxx/

-:27: WARNING:SPACING: Unnecessary space before function pointer arguments
#27: FILE: include/linux/perf_event.h:571:
+	struct pmu *(*get)		(struct pmu *pmu);

-:30: WARNING:SPACING: Unnecessary space before function pointer arguments
#30: FILE: include/linux/perf_event.h:574:
+	 void (*put)			(struct pmu *pmu);

-:38: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#38: FILE: include/linux/perf_event.h:1118:
+extern void perf_pmu_free(struct pmu *pmu);

-:95: WARNING:LONG_LINE: line length of 111 exceeds 100 columns
#95: FILE: kernel/events/core.c:11769:
+	if (WARN_ONCE((!!pmu->get) ^ (!!pmu->put), "Can not register a pmu with only get or put defined.\n")) {

total: 0 errors, 4 warnings, 1 checks, 113 lines checked
1a85dc884b6d drm/i915/pmu: Let resource survive unbind
e7bb5806e940 drm/i915/pmu: Fix crash due to use-after-free
-:110: WARNING:MISSING_FIXES_TAG: The commit message has 'stable@', perhaps it also needs a 'Fixes:' tag?

total: 0 errors, 1 warnings, 0 checks, 66 lines checked
26c2507815e4 drm/i915/pmu: Rename cpuhp_slot to cpuhp_state
1b5adbd7c6e4 drm/i915/pmu: Stop setting event_init to NULL
c98937826402 drm/i915/pmu: Replace closed with registered
f21a1a02ada7 drm/i915/pmu: Remove pointless synchronize_rcu() call
ec2a46c1535d drm/i915/pmu: Release open events when unregistering





[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux