On 11/05/2013 08:05 PM, Chen Gang wrote: > On 11/05/2013 07:11 PM, David Howells wrote: >> Chen Gang <gang.chen@xxxxxxxxxxx> wrote: >> >>>> Userspace sometimes depends on the name in the guard macro:-/ >>> >>> "the guard macro" is only for prevent itself from being included by >>> multiple times (an id used by itself -- like a handle), it is not an id >>> to let other files know about it (it is not a normal using way). >> >> Whilst that *should* be true, it isn't actually true. See: >> >> grep -r _LINUX_.*_H /usr/include/ | grep -v ^/usr/include/linux/ >> >> for example. Also who knows what all those autoconf scripts out there look >> for? >> > > Oh... the real world is really not quite perfect. :-/ > > >> However, thinking about it some more, you're probably safe with respect to >> userspace as scripts/headers_install.h strips off the _UAPI prefix on the >> guard macros - just as long as you don't change the rest of the macro name. >> > I will preparing the patch for it, it will cover "include/uapi/*" and "arch/*/include/uapi/*", the patch will only add "_UAPI" for the guard macros which miss it. Welcome any additional suggestions and completions. Thanks. > In honest, I really did not think more about it. > > Only adding _UAPI (not touch others) can completely fix one style issue: > separate "uapi/*" from other sub-directories in "include/*" > > So for me, we can continue improve this patch: add "_UAPI" for all guard > macro under "include/uapi/*" (also include "include/uapi/linux"). > > > Thanks. > -- Chen Gang _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
