On Fri, Nov 1, 2013 at 11:47 AM, Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> wrote: >> I was instructed to keep the JIRA issue codes on the patch, but have >> to wonder why I don't see any of these in the history. Let me know if >> those shouldn't be there. > > Personally I don't think references to internal systems provide much > value, though others may disagree. In any case the commit message has to > be self sufficient without the referenced info. (And no complaints about > that in your patch!) Yeah, if crucial information is hidden behind internal references that's not great. And I think for that reason such stuff is a bit frowned upon. But if it helps you to keep track of the patches I don't mind. I think the usual approach though is to smash a Changeset-Id: tag onto the patch and use that to track the patch flow. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
