|
Hello Vinschen, Hope you are doing well. I am Chaitanya from the linux graphics team in Intel. This mail is regarding a regression we are seeing in our CI runs[1] on drm-tip[2] repository. Since the version CI_DRM_14817[3], we are seeing the following regression ````````````````````````````````````````````````````````````````````````````````` 4>[ 10.361988] Hardware name: Intel Corporation Arrow Lake Client Platform/MTL-S UDIMM 2DPC EVCRB, BIOS MTLSFWI1.R00.3473.D80.2311222130 11/22/2023 <4>[ 10.362613] Call Trace: <4>[ 10.363227] <TASK> <4>[ 10.363835] dump_stack_lvl+0x82/0xd0 <4>[ 10.364446] register_lock_class+0x795/0x7e0 <4>[ 10.365054] ? __free_object+0xa1/0x340 <4>[ 10.365659] ? lockdep_hardirqs_on+0xc1/0x140 <4>[ 10.366261] __lock_acquire+0x73/0x2230 <4>[ 10.366857] ? _raw_spin_unlock_irqrestore+0x58/0x70 <4>[ 10.367451] lock_acquire+0xd9/0x2f0 <4>[ 10.368038] ? igc_ptp_clear_tx_tstamp+0x28/0x60 [igc] <4>[ 10.368638] _raw_spin_lock_irqsave+0x3d/0x60 <4>[ 10.369212] ? igc_ptp_clear_tx_tstamp+0x28/0x60 [igc] <4>[ 10.369794] igc_ptp_clear_tx_tstamp+0x28/0x60 [igc] <4>[ 10.370369] igc_ptp_set_timestamp_mode.isra.0+0x20b/0x230 [igc] <4>[ 10.370944] igc_ptp_reset+0x31/0x180 [igc] <4>[ 10.371513] igc_reset+0xb4/0x100 [igc] <4>[ 10.372083] igc_probe+0x797/0x8e0 [igc] <4>[ 10.372647] pci_device_probe+0x95/0x120 <4>[ 10.373199] really_probe+0xd9/0x370 <4>[ 10.373748] ? __pfx___driver_attach+0x10/0x10 <4>[ 10.374291] __driver_probe_device+0x73/0x150 <4>[ 10.374835] driver_probe_device+0x19/0xa0 <4>[ 10.375375] __driver_attach+0xb6/0x180 <4>[ 10.375908] ? __pfx___driver_attach+0x10/0x10 <4>[ 10.376438] bus_for_each_dev+0x77/0xd0 <4>[ 10.376968] bus_add_driver+0x110/0x240 <4>[ 10.377492] driver_register+0x5b/0x110 <4>[ 10.378015] ? __pfx_igc_init_module+0x10/0x10 [igc] <4>[ 10.378551] do_one_initcall+0x5c/0x2b0 <4>[ 10.379079] ? kmalloc_trace_noprof+0x22f/0x290 <4>[ 10.379602] ? do_init_module+0x1e/0x210 <4>[ 10.380131] do_init_module+0x5f/0x210 <4>[ 10.380651] load_module+0x1d44/0x1fc0 <4>[ 10.381173] ? init_module_from_file+0x86/0xd0 <4>[ 10.381691] init_module_from_file+0x86/0xd0 <4>[ 10.382206] idempotent_init_module+0x17c/0x230 <4>[ 10.382723] __x64_sys_finit_module+0x56/0xb0 <4>[ 10.383237] do_syscall_64+0x66/0x140 <4>[ 10.383751] entry_SYSCALL_64_after_hwframe+0x76/0x7e <4>[ 10.384264] RIP: 0033:0x7f668aeff95d ````````````````````````````````````````````````````````````````````````````````` Details log can be found in [4]. We have identified the following patch [5] to be the first "bad" commit ````````````````````````````````````````````````````````````````````````````````````````````````````````` commit 86167183a17e03ec77198897975e9fdfbd53cb0b Author: Corinna Vinschen
vinschen@xxxxxxxxxx Date: Tue Apr 23 12:24:54 2024 +0200 igc: fix a log entry using uninitialized netdev During successful probe, igc logs this: [ 5.133667] igc 0000:01:00.0 (unnamed net_device) (uninitialized): PHC added ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ The reason is that igc_ptp_init() is called very early, even before register_netdev() has been called. So the netdev_info() call works on a partially uninitialized netdev. Fix this by calling igc_ptp_init() after register_netdev(), right after the media autosense check, just as in igb. Add a comment, just as in igb. ````````````````````````````````````````````````````````````````````````````````````````````````````````` Could you please check why the patch causes this regression and provide a fix if necessary? Thank you. Regards Chaitanya [1]
https://intel-gfx-ci.01.org/tree/drm-tip/index.html? [4]
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14817/bat-arls-1/boot0.txt [5] https://cgit.freedesktop.org/drm-tip/commit/?id=86167183a17e03ec77198897975e9fdfbd53cb0b |
