Re: [PATCH] drm/i915: HSW GT3 Slices: exec flag to warn kernel that userspace is using predication

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 22, 2013 at 03:33:16PM -0200, Rodrigo Vivi wrote:
> I still think state_default is working, enough and simpler...
> or do you really want me to use config and max_config instead?

I think keeping the hw config separate from the requested config helps a
lot when reviewing the code in 6 months time. See pc8 for a recent
example where we also need to track hw vs sw state. Similarly in trying
to split the code that implements the policy and that implements the
mechanism.

The devil is in the details, of course, and so this suggestion may
indeed suck when implemented. You are free to refute any suggestion with
a good reason. :)
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux