On Wed, Oct 16, 2013 at 04:30:57PM +0200, Bas Wijnen wrote: > On Tue, Oct 15, 2013 at 09:25:41AM +0100, Chris Wilson wrote: > > > This does indeed stop the server from crashing, but actually makes the > > > problem worse: it used to play video for a few minutes and then crash > > > when trying. With my patch it would play video for a few minutes and > > > then present black screens when trying. With your patch, it presents > > > black screens from the start. > > > > Start of video, or beginning of X? > > Beginning of X. After starting and logging in, I can play them for a > few minutes; afterwards it will crash. Still weird. Can you attach the Xorg.log from the black screen and/or crash. > > > I must say I'm not entirely sure if the backtrace I sent you is a > > > "typical" case; I managed to crash it sooner than usual, so perhaps it > > > wasn't the bug that I triggered before. It did stop the crashing > > > however. > > > > > > > However, that still leaveas the question as to how you ended up being > > > > unable to allocate bo... > > I didn't check the backtrace myself, but when I wrote my shotgun-patch, > the problem was that pixmap_private was NULL; bo is in there, right? So > at least in that case, it could never have allocated it, or at least it > couldn't store the pointer. I doubt we failed to malloc the intel_pixmap, so the reason why the intel_pixmap would be NULL is more likely due to failure to allocate the GPU buffer object i.e. they are semantically interchangeable, an attached intel_pixmap to a Pixmap implies we have a GPU bo. Similarly checking for the intel_pixmap should be enough to assert that the GPU bo exists. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
