On Sat, Oct 12, 2013 at 1:19 AM, Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx> wrote: > But I don't want this fix (once I fix the locking) blocked on > those tests, since they'll probably take me a few days and people are > already using the original version, which is missing the locks for the > backlight class and ASLE call sites. btw for fixing the asle mutex_lock-in-irq-context issue we might want to simply use a trylock - Iirc the opregion spec explicitly allows us to abort the request as "driver busy with modeset ops". Imo both approaches of either delaying the request to a workqueue or using the asle return value feel equally risky wrt funky bioses doing stupid things. In both cases we need to get real-world testing, but using the trylock + abort is simpler in our own code ;-) -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
