Re: [PATCH v5 0/4] Fix Win8 backlight issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 11, 2013 at 11:00 PM, Yves-Alexis Perez <corsac@xxxxxxxxxx> wrote:
> On sam., 2013-10-12 at 00:10 +0200, Rafael J. Wysocki wrote:
>> On Friday, October 11, 2013 12:42:43 PM Josh Boyer wrote:
>> > On Fri, Oct 11, 2013 at 9:27 AM, Aaron Lu <aaron.lu@xxxxxxxxx> wrote:
>> > > v5:
>> > > 1 Introduce video.use_native_backlight module parameter and set its
>> > >   value to false by default as suggested by Rafael. For Win8 systems
>> > >   which have broken ACPI video backlight control, the parameter can be
>> > >   set to 1 in kernel cmdline to skip registering ACPI video's backlight
>> > >   interface. Due to this change, the acpi_video_verify_backlight_support
>> > >   is moved from video_detect.c to video.c - patch 3/4;
>> >
>> > That's a fairly untenable position for distro kernels to be in.  They
>> > now have to ask every user that reports an issue with the backlight to
>> > try setting that option on the command line.  While I appreciate the
>> > setting breaks things for some people, doesn't the Win8 issue impact
>> > far more people?  Shouldn't it be defaulted to true?
>>
>> Well, we have a rule in the kernel not to introduce regressions for users even
>> if they are minority.
>
> Well, for some users, the regression actually happened when support for
> Win8 OSI call was introduced.

Yes, this is true.  It's probably one of the more common bug reports
we get in this area.  Kernels prior to that have working backlight,
kernels after that don't.

josh
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux