2013/10/11 Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>: > This may need work if other platforms do the same thing, but in the > meantime we should avoid looking at HSW specific bits in this generic > function. > > Signed-off-by: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx> > --- > drivers/gpu/drm/i915/intel_display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index 53c4ea8..e1b19b4 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -10667,7 +10667,7 @@ void i915_redisable_vga(struct drm_device *dev) > * level, just check if the power well is enabled instead of trying to > * follow the "don't touch the power well if we don't need it" policy > * the rest of the driver uses. */ > - if (HAS_POWER_WELL(dev) && > + if (IS_HASWELL(dev) && But today, HAS_POWER_WELL is exactly the same thing as IS_HASWELL, so you're not really changing anything besides coding style :) I know you have plans to add power well support for other platforms, so: Reviewed-by: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx> But this patch really makes sense only when inside some bigger series that we haven't seen yet. I'll leave the decision to merge it or not to Daniel. > (I915_READ(HSW_PWR_WELL_DRIVER) & HSW_PWR_WELL_STATE_ENABLED) == 0) > return; > > -- > 1.8.3.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Paulo Zanoni _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
